Fix contract flaws (LP trap / msg.sender + oracle mismatch)#2
Open
0xJonHoldsCrypto wants to merge 1 commit intohemilabs:mainfrom
Open
Fix contract flaws (LP trap / msg.sender + oracle mismatch)#20xJonHoldsCrypto wants to merge 1 commit intohemilabs:mainfrom
0xJonHoldsCrypto wants to merge 1 commit intohemilabs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes two critical contract flaws: (1) an LP trap issue where liquidity providers' shares were incorrectly credited to the router contract instead of the user, and (2) an oracle price calculation error where the token ratio was inverted (A/B instead of B/A) in the Uniswap V3 TWAP adapter.
Key changes:
- Added
receiverparameter toaddLiquidityfunction to enable explicit control over LP share ownership - Refactored oracle price calculation logic to properly handle token ordering and price inversion
- Updated interface definitions to maintain consistency across contracts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| contracts/FpmmAMM.sol | Added receiver parameter to addLiquidity function and updated LP share crediting logic to use receiver instead of msg.sender |
| contracts/SimpleRouter.sol | Updated addLiquidity call to pass msg.sender as receiver parameter, ensuring LP shares go to the user instead of the router |
| contracts/UniV3EthUsdTwapOracleAdapter.sol | Rewrote price calculation logic to correctly handle token0/token1 ordering and properly compute price ratios with decimal adjustments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues with msg.sender implementation crediting the proxy contract with the LP deposit resulting in an LP trap. Also, the oracle was referencing the quote token in the improper order A/B - fixed for B/A to match Uniswap method.