chore: add missing exports and type-check validation#13
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing exports and type-check validation to improve the project's type safety and API completeness. The changes consolidate type exports using wildcard syntax and add TypeScript type checking to the CI pipeline.
Key changes:
- Consolidates individual type exports into wildcard exports for cleaner syntax
- Adds comprehensive test object setup to reduce duplication in test files
- Implements type-checking validation in both package.json scripts and CI workflow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Replaces individual type exports with wildcard exports for all types |
| src/eol/utils.test.ts | Adds shared default metadata object and uses spread operator in tests |
| src/cdx-xml-to-json.test.ts | Adds optional chaining and non-null assertions for type safety |
| package.json | Adds type-check script for TypeScript validation |
| .github/workflows/validate.yml | Adds CI job for type checking tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
facundo-herodevs
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.