-
Notifications
You must be signed in to change notification settings - Fork 234
feat: migrate to color.app from @heroku/heroku-cli-util #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Migrates 43 files to use the semantic color.app() function from @heroku/heroku-cli-util instead of color.magenta() for app names. This is the first PR in a series to migrate from @heroku-cli/color to the new semantic color system in @heroku/heroku-cli-util. Changes: - Update @heroku/heroku-cli-util to 10.3.0 - Migrate 43 files to import color from @heroku/heroku-cli-util - Replace color.magenta(app) with color.app(app) for app names - Files only migrated if they exclusively use color.app() - Files using other color functions will be migrated in future PRs Affected areas: - commands/apps/, certs/, config/, domains/, maintenance/ - commands/pg/backups/, pipelines/, ps/, releases/ - lib/apps/, pipelines/, run/, webhooks/ - oldCommands/pg/
dc16be9 to
f542f95
Compare
|
@eablack This looks great! I still see two instances of |
|
@eablack Also just seeing this, I think packages/cli/src/commands/apps/create.ts needs an update to import and app related colors. That's should be the last bit for this part of the migration. |
michaelmalave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the final updates this looks complete. Nice work on this!
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002T2hvTYAR/view
Summary
This is the first PR in a series to migrate from
@heroku-cli/colorto the new semantic color system in@heroku/heroku-cli-util. This PR specifically migrates all usage ofcolor.app()for application names. It also resolves linting errors along the way.Changes
@heroku/heroku-cli-utilto 10.3.0colorfrom@heroku/heroku-cli-utilcolor.magenta(app)withcolor.app(app)for app name referencescolor.app()newColor.appto preserve other color migrations for future PRsSemantic Color Benefits
The new color system provides semantic meaning:
color.app()→ Purple with ⬢ symbol (instead of genericcolor.magenta())Files Updated
Commands (33 files)
commands/apps/- destroy, errors, favorites, join, leave, unlockcommands/certs/- add, auto/disable, info, remove, updatecommands/config/editcommands/domains/- clear, removecommands/maintenance/- off, oncommands/pg/backups/- 6 filescommands/pipelines/- add, diff, promote, remove, setup, updatecommands/ps/- index, scale, typecommands/releases/rollbackcommands/usage/addonsLib (4 files)
lib/apps/app-transferlib/pipelines/setup/poll-app-setupslib/run/dynolib/webhooks/baseTest Plan
Migration Plan
This is PR 1 of 17 in the color migration series. See COLOR_MIGRATION_PLAN.md for the full roadmap:
color.app(this PR)color.spacecolor.addonReview Notes
color.green,color.cyan, etc.) intentionally left on old import