feat: migrate to color.space from @heroku/heroku-cli-util #3469
+525
−444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates all space name references to use the new semantic color.space() function from @heroku/heroku-cli-util instead of generic colors like color.cyan() or color.green(). Changes: - Updated 15 command files in packages/cli/src/commands/spaces/ - Updated apps/index.ts to use color.space() for space references - Changed all imports from @heroku-cli/color to @heroku/heroku-cli-util - Updated color.cmd() to color.command() where affected by import changes - Updated corresponding test files to match new color output The new color.space() function provides consistent bold blue formatting with the ⬡ symbol prefix for Private Space names throughout the CLI. Part of the color system migration plan (PR 2 of 17).
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all Private Space name references to use the new semantic
color.space()function from@heroku/heroku-cli-utilinstead of generic colors likecolor.cyan()orcolor.green().This is PR 2 of 17 in the color system migration plan, focusing on adopting the semantic color for Private Spaces.
I also took this opportunity to add the new pull request template.
Changes Made
packages/cli/src/commands/spaces/to usecolor.space()apps/index.tsto usecolor.space()for space references@heroku-cli/colorto@heroku/heroku-cli-utilin affected filesVisual Output
The new
color.space()function provides consistent bold blue formatting with the ⬡ symbol prefix for Private Space names throughout the CLI.Examples:
Destroying space ⬡ my-spaceCreating space ⬡ my-space in team...Apps in space ⬡ my-spaceType of Change
Feature Additions (minor semver update)
Testing
Notes:
Steps:
./bin/run spaces- verify space names are colored with ⬡ symbol./bin/run spaces:info --space <name>- verify space name in output./bin/run apps --space <name>- verify "Apps in space" headerRelated Issues
Part of the color system migration tracking issue -- https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002T2hvTYAR/view