Open
Conversation
spion
reviewed
Jun 22, 2019
| if (this.isSingletonProvided(Klass)) { | ||
| throw new Error(`The singleton ${Klass.name} is already provided.`); | ||
| } | ||
| this.providedSingletons.set(Klass, true); |
Contributor
There was a problem hiding this comment.
can we refactor so the same map is used for provides and overrides?
Contributor
There was a problem hiding this comment.
on second thought maybe not, you might want to override before providing.
spion
reviewed
Jun 22, 2019
| if (this.hasSingleton(Klass)) { | ||
| return this.getExistingSingleton(Klass); | ||
| } | ||
| if (!this.isSingletonProvided(Klass)) { |
spion
reviewed
Jun 22, 2019
| load<T>(Klass: ConstructorOrFactory<App, T>): void { | ||
| this.getSingleton(Klass); // force initialization; | ||
| return; | ||
| if (this.isSingletonProvided(Klass)) { |
Contributor
There was a problem hiding this comment.
In this case it should be just getSingleton (multiple loads should be ok)
Contributor
There was a problem hiding this comment.
I think we need to re-do this with a bit of thinking.
Contributor
Author
There was a problem hiding this comment.
Redo this PR or the loading-once-or-twice mechanics? Fine with both really.
Contributor
There was a problem hiding this comment.
We need to think whether we want to allow loading plugins within plugins, because thats what implies multiple load calls are OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the concept of "providing singletons".
Modules will be expected to provide stuff to other modules, and doing
app#getSingletonwill throw if stuff wasn't previously provided.Still WIP.