Skip to content

Update steps.rb#10

Open
gokcesurenkok wants to merge 1 commit intohidroh:masterfrom
gokcesurenkok:patch-2
Open

Update steps.rb#10
gokcesurenkok wants to merge 1 commit intohidroh:masterfrom
gokcesurenkok:patch-2

Conversation

@gokcesurenkok
Copy link

No description provided.

@hidroh
Copy link
Owner

hidroh commented Jan 28, 2017

Seems like your PR introduces a dependency that requires Ruby >= 2.0 which is more than what currently supported.

@wiggly
Copy link
Contributor

wiggly commented Mar 2, 2017

@hidroh I don't think so, I think that the versions have simply changed underneath everything and now bundler is pulling in addressable 2.5 which requires ruby >= 2.0.0.

I have created a PR to fix this. If that gets merged then the other outstanding two PRs can be rebased off of it.

@hidroh
Copy link
Owner

hidroh commented Mar 3, 2017

@gokcesurenkok may be a little explanation of what you're trying to do here?

@hidroh
Copy link
Owner

hidroh commented Mar 3, 2017

Sorry just saw #8, let me read thru it.

@hidroh
Copy link
Owner

hidroh commented Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants