-
-
Notifications
You must be signed in to change notification settings - Fork 209
Adding Trade & Arrows UI to finplot chart #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Better API for drawing arrow
Need to be removed from repository)
Clean up some finplot code. Start migration from PyQt5 to PyQt6. Does not compile yet : need QCoreApplication
|
Hi and thanks for your work! There is one thing I'd ask of you first, and that is to squash away the nonsense commits (like "Remove useless example", "Clean finplot examples", remove things like "sys.path.append('C:/perso/trading/anaconda3/finplot')" in the code etc). There's also a bunch of unintentional white-space changes which would be nice to get edited out, if possible. The second thing is I'd like to discuss are the arrows. There already is an API for adding triangles en masse pointing up, down, left, right of any color. Adding them one by one, as in your api, limits performance substantially when displaying a multi-year series of HFT. Also, I'd like the plotting library to be both finance-specific (candlestick plots) and generic (lines and bars). Adding two separate functions for "orders" and "trades" might be good, but seems a bit overly specific. The I especially like what you did with your backtester! I'd like to take it for a spin and do the same with your finplot modifications, and come back with more thoughts. I'm travelling for the next week, so this might take some time unfortch. :) |
|
Thank you for taking the time to review this PR 👍
Do not hesitate to add comments if you have any! Cheers. |
Hi Sir,
I would like to share with you the little additions I have made to your amazing work.
My goal is to code a backtrading UI in Qt, based on backtrader, which displays a history of trades and a chart window using finplot.
You can check my github repository here : backtrader-pyqt-ui
Don't hesitate to change anythings in this PR and ask me if you have questions.
Best Regards,
Skinok.