Conversation
|
@captn3m0 Can you please look into this PR ? |
|
@captn3m0 All requested changes are done. |
|
@captn3m0 Can you please review the PR again ? All requested changes are done. |
captn3m0
left a comment
There was a problem hiding this comment.
Changes LGTM. However, I'm unsure of how the deployment script works, what ruby/bundler version it currently runs on, and that might break things.
|
It runs rubygem-jekyll-4.3.2, ruby-3.1.4,1, ruby31-gems-3.4.10. |
|
So the deployment is just a Running But that means it will ignore everything in the Gemfile, so the benefits of this PR are ignored. Using Managed to fix #57 while debugging this, so that should give us a clean solution that keeps working. Will push my changes for #57 in this PR, and merge this PR. We can switch our jekyll invocation in the deploy script to something like the following, after this is merged (Based on https://jekyllrb.com/tutorials/using-jekyll-with-bundler/): |
|
The deployment 'script' is a cron job that does It looks like Nemo has access to that box. The website lives in the wiki jail, and the job runs as www ( |
|
Will get to this soon. |

Lock dependencies to known working versions to ensure builds work in future as well.