update code by himanikh · Pull Request #4 · himanikh/CodeGuruReviewer

himanikh · 2019-12-20T02:42:24Z

No description provided.

himanikh · 2019-12-20T02:46:36Z

src/main/java/com/company/sample/application/SalesSystem.java

+        //Start list order thread
+        ListOrderThread listOrderThread = new ListOrderThread();
+
+        DateFormat currentDateFormat = new SimpleDateFormat("dd MMM yyyy");


Recommendation generated by Amazon CodeGuru Reviewer

The SimpleDateFormat object was created without setting the time zone. Make sure that you want to use the default time zone or use letter z, Z or X in the pattern. Otherwise, if you don’t call setTimeZone() on the created SimpleDateFormat object, you might get an unexpected date and time when using the object.

himanikh · 2020-02-02T23:21:16Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact


Can you expand on this?

himanikh · 2020-02-02T23:24:43Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-02-04T01:00:45Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-02-04T22:20:55Z

CODE_OF_CONDUCT.md

@@ -0,0 +1,4 @@
+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).


Can you expand on this?

himanikh · 2020-02-06T01:23:02Z

CODE_OF_CONDUCT.md

@@ -0,0 +1,4 @@
+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact


Can you expand on this?

himanikh · 2020-02-06T03:51:17Z

CODE_OF_CONDUCT.md

@@ -0,0 +1,4 @@
+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact


Can you expand on this?

himanikh · 2020-03-10T17:07:53Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:11:50Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:11:52Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:11:54Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:11:56Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:11:58Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:00Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:02Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:04Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:05Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:07Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:09Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:11Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:13Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:15Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:16Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:18Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:20Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:22Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:24Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:26Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T17:12:27Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:11Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:12Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:14Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:16Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:18Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:19Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:21Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:23Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:25Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:26Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:28Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:30Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:32Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:34Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:35Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:37Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:39Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:41Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:42Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:44Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:46Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:48Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:50Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:52Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-10T23:21:53Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-13T15:05:07Z

CODE_OF_CONDUCT.md

@@ -0,0 +1,4 @@
+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact


Can you expand on this?

himanikh · 2020-03-13T15:09:14Z

src/main/java/com/company/sample/application/ListOrderThread.java

+            }
+
+            productNames = productNames.substring(2);
+            System.out.println("Product Names : " + productNames);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This code contains a potential information leakage in the log handling for the following call(s): 'phi' (line 62). You are handling this log data through: 'PrintStream.println()' (line 81). Please use your organization-specific sensitive information handling loggers or redaction. Learn more about information leakage (external link).

himanikh · 2020-03-13T15:09:14Z

src/main/java/com/company/sample/application/ListOrderThread.java

+                    Date todayDate = todayFormat.parse(this.today);
+                    if(Util.isSameDay(orderDate, todayDate)) {
+                        String orderAsString = objectMapper.writeValueAsString(SalesSystem.orders.get(orderDate));
+                        System.out.println(orderAsString);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This code contains a potential information leakage in the log handling for the following call(s): 'ObjectMapper.<init>' (line 58). You are handling this log data through: 'PrintStream.println()' (line 69). Please use your organization-specific sensitive information handling loggers or redaction. Learn more about information leakage (external link).

himanikh · 2020-03-13T15:09:14Z

src/main/java/com/company/sample/application/ListOrderThread.java

+                    Date todayDate = todayFormat.parse(this.today);
+                    if(Util.isSameDay(orderDate, todayDate)) {
+                        String orderAsString = objectMapper.writeValueAsString(SalesSystem.orders.get(orderDate));
+                        System.out.println(orderAsString);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This code contains a potential information leakage in the log handling for the following call(s): 'ConcurrentHashMap.get()' (line 68). You are handling this log data through: 'PrintStream.println()' (line 69). Please use your organization-specific sensitive information handling loggers or redaction. Learn more about information leakage (external link).

himanikh · 2020-03-13T15:09:14Z

src/main/java/com/company/sample/application/ListOrderThread.java

+                    objectMapper.setDateFormat(myFormat);
+                    Date todayDate = todayFormat.parse(this.today);
+                    if(Util.isSameDay(orderDate, todayDate)) {
+                        String orderAsString = objectMapper.writeValueAsString(SalesSystem.orders.get(orderDate));


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This code contains a potential information leakage in the log handling for the following call(s): 'ConcurrentHashMap.get()' (line 68). You are handling this log data through: 'ObjectMapper.writeValueAsString()' (line 68). Please use your organization-specific sensitive information handling loggers or redaction. Learn more about information leakage (external link).

himanikh · 2020-03-13T15:09:14Z

src/main/java/com/company/sample/application/SalesSystem.java

+        //Start list order thread
+        ListOrderThread listOrderThread = new ListOrderThread();
+
+        DateFormat currentDateFormat = new SimpleDateFormat("dd MMM yyyy");


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The SimpleDateFormat object was created without setting the time zone. Make sure that you want to use the default time zone or use letter z, Z or X in the pattern. Otherwise, if you do not call setTimeZone() on the created SimpleDateFormat object, you might get an unexpected date and time when using the object.

himanikh · 2020-03-14T18:28:39Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-25T18:45:25Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

himanikh · 2020-03-25T18:46:41Z

CODE_OF_CONDUCT.md

+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+opensource-codeofconduct@amazon.com with any additional questions or comments.


Can you expand on this?

update code

6cf1b10

himanikh commented Dec 20, 2019

View reviewed changes

himanikh commented Feb 2, 2020

View reviewed changes

himanikh commented Feb 4, 2020

View reviewed changes

himanikh commented Feb 6, 2020

View reviewed changes

himanikh commented Mar 10, 2020

View reviewed changes

himanikh commented Mar 13, 2020

View reviewed changes

himanikh commented Mar 14, 2020

View reviewed changes

himanikh commented Mar 25, 2020

View reviewed changes

		@@ -0,0 +1,4 @@
		## Code of Conduct
		This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).

Conversation

himanikh commented Dec 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment