Skip to content

Conversation

@himkt
Copy link
Owner

@himkt himkt commented Dec 14, 2025

No description provided.

@himkt himkt requested a review from Copilot December 14, 2025 13:24
@himkt himkt self-assigned this Dec 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation comments to the lower_bound and upper_bound functions in the search module, improving code documentation by describing what each function returns.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,3 +1,4 @@
/// Returns the smallest index on [l, r) satisfying the condition.
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation refers to parameters 'l' and 'r', but the function signature uses 'range'. Update the doc comment to use 'range' instead of '[l, r)' for consistency with the actual parameter name.

Copilot uses AI. Check for mistakes.
}
}

/// Returns the largest index on [l, r) satisfying the condition.
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation refers to parameters 'l' and 'r', but the function signature uses 'range'. Update the doc comment to use 'range' instead of '[l, r)' for consistency with the actual parameter name.

Suggested change
/// Returns the largest index on [l, r) satisfying the condition.
/// Returns the largest index in the range [range.start, range.end) satisfying the condition.

Copilot uses AI. Check for mistakes.
@himkt himkt merged commit 34790f3 into main Dec 14, 2025
1 check passed
@himkt himkt deleted the docs-search branch December 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants