Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

Conversation

@himself65
Copy link
Owner

@himself65 himself65 commented Nov 12, 2023

This PR will add some new features.

  • y-sqlite: for desktop
  • add createLazyProvider in y-utils

@vercel
Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
refine ❌ Failed (Inspect) Nov 14, 2023 4:41pm
refine-docs ❌ Failed (Inspect) Nov 14, 2023 4:41pm

@codecov
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (3665bcd) 98.26% compared to head (a488507) 88.53%.

Files Patch % Lines
packages/y-utils/src/lazy-provider.ts 62.31% 124 Missing ⚠️
packages/y-utils/src/utils.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   98.26%   88.53%   -9.74%     
==========================================
  Files          12       14       +2     
  Lines         982     1326     +344     
  Branches      207      226      +19     
==========================================
+ Hits          965     1174     +209     
- Misses         17      152     +135     
Flag Coverage Δ
apps ?
packages 88.13% <63.37%> (-9.10%) ⬇️
server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himself65
Copy link
Owner Author

I'm thinking to use levelDB instead

Copy link
Owner Author

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocksdb is not stable on the node.js side. I'm thinking of moving it back to SQLite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants