Dev3.0.17 popup #239
Open
Dev3.0.17 popup #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when a sharescreen etc starts, the popup keeps the presentation container.
Finally it's fixed. Does this make other problems?
Seems to make no difference...
And add the comments on what is affected by these changes.
update 3.0.13
bump to 3.0.14
The style changing panel is now working properly.
Fix: chat scrolls even with popped up presentation
When the messages are accumulated in the message panel with a user's scroll to above, a button appears to catch the newest message on the bottom . Previously the button did not work due to the global replacement of window.requestAnimationFrame by popup.rAF (and cAF)
I couldn't actually figure out to what these changes affect...
No change observed, so commented out. Leave as comments for a recording purpose.
This fixes the chronic problem of disability of fullscreen of the popup in the main monitor (sub monitor does not have the problem)
Tested window resizing with/without the change, but I didn't see any difference. I leave the change because the video alignment should not be affected by the popup window size.
Keep using the original code, in which window.rAF/cAF (replace with those of popup at presentation/component.jsx) is used.
Backup original rAF/cAF to avoid the bad effects from the globally replaced popup.rAF/cAF. After the fix of zoom failure in the full-screened popup on the main monitor by hacking the window.requestAnimationFrame/window.cancelAnimationFrame, some of BBB's function including the 'catch the latest chat message' button is found broken. This PR fetches the original window.rAF/cAF and uses them for two BBB components (chat-graphql and video-provider/video-list). The emoji-rain component has left untouched (only leaving commented out codes) because no difference has been observed.
Revert 5b7dc91, because it breaks the shape handling on the main window when the popup is closed.
This was first merged by 0a78781, which nicely fixed the problem of style selector panel (button continue to be pushed. Actually the 'e.target.dispatchEvent(pointerUpEvent)' did not seem necessary even then. However, this patch has a severe conflict with 2cdebe9 , which globally replace window.HTMLElement with popup.HTMLElement so that resize and rotate handle becomes operatable on the popup (a problem caused by dom.ts of tldraw which internally refers HTMLElement.
A 'Prefer default export on a file with single export' occurred because there is only one export in the file.
Remove Funny JA font from THIS PR
By mistake it had been sitting at inside of Fullscreen event listener.
change the name of a constant
See the comment. I force re-rendering of the slide SVG upon the popup window resizing.
Test3017merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems remained
depending on browser and OS, fullscreen in the same monitor does not expand the presentation (if you move to another monitor, it works). If it happens, you click the screen then tldraw realizes and the screen size has changed (but not always...).the above problem is solved. Now zooming (by wheel or by clicking the zoom button) is the only problem remained. -> accidentally fixed(?) by 5726c9e, after the evaporation of cache???-> solved by replacing requestAnimationFrame and cancelAnimationFrame with those of popup (cc3d507).resize by dragging the resize handles does not work (focus is lost); dom.ts in tldraw causes the problemstyle panel including the color picker does not work well. When mouse-down, the mouse-up event is not caught, behaving as if mouse is kept down when hovered over the button, picking up every color that mouse hover. The reason is in this file: tldraw-alpha30/packages/tldraw/src/lib/ui/components/primitives/ButtonPicker.tsxFonts are not properly loaded on the popup, e. g., the var(--tl-font-draw) font which is the default on latin languages.Frequent 3006 error from graphql since 3.0.13 or 14 (not happening on 3.0.11)Firefox suffers an error of too much recursion of font measurement when the text font is changed more than twice (or once?). The tldraw files packages/editor/src/lib/editor/managers/TextManager.ts, packages/tldraw/src/lib/shapes/text/TextShapeUtil.tsx, and packages/editor/src/lib/utils/WeakMapCache.ts may account for it.-> fixed by 3113f60Additional features
add Kosugi-Maru font to look a text funnier for the Japanese locale-> Dev3.0.15 use better font #235 (only for popup)ToDo
Caution
Tldraw2.0 internally (and implicitly) uses global variables/functions, making some conflicts with popup, including: