Skip to content

Conversation

@SFGrenade
Copy link
Member

some todos left

@SFGrenade
Copy link
Member Author

will note some changes i saw in more comments

@SFGrenade
Copy link
Member Author

for the MAPI itself: currently the language get isn't hooked

@SFGrenade
Copy link
Member Author

SFGrenade commented Dec 16, 2025

  • ShowFPS worked flawlessly, it's also a really simple mod, practically not interacting with MAPI aside from being loaded
  • SFCore needed changes
    • using TMPro; -> using TMProOld;
    • On.UIManager.RefreshAchievementsList -> On.MenuAchievementsList.PreInit
    • AchievementsList.achievements is private now
    • DesktopPlatform.EncryptedSharedData -> DesktopPlatform.RoamingSharedData
      • this is for achievements, menu styles and some shit like that
  • HollowKnightAchievementManager needed changes
    • Language -> TeamCherry.Localization edit: fixed with type "forwarding"

@SFGrenade
Copy link
Member Author

SFGrenade commented Dec 16, 2025

for HollowKnightAchievementManager: Satchel seems to work fine, BUT trying to create a menu errors with

[ERROR]:[API] - Error creating menu for ICustomMenuMod Hollow Knight Achievement Manager
[ERROR]:[API] - System.TypeLoadException: Could not resolve type with token 01000102 from typeref (expected class 'Language.Language' in assembly 'Assembly-CSharp, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null')
[ERROR]:[API] -   at Modding.Menu.MenuBuilder.AddControls (Modding.Menu.IContentLayout layout, Modding.Menu.INavigationGraph navgraph, System.Action`1[T] action) [0x00033] in <60d0b6c1d8f94e9285cfca026540e40c>:0 
[ERROR]:[API] -   at Modding.Menu.MenuBuilder.AddControls (Modding.Menu.IContentLayout layout, System.Action`1[T] action) [0x00008] in <60d0b6c1d8f94e9285cfca026540e40c>:0 
[ERROR]:[API] -   at Satchel.BetterMenus.Utils.AddBackButton (Modding.Menu.MenuBuilder builder, Satchel.BetterMenus.Menu menuRef, UnityEngine.UI.MenuButton& backButton) [0x00014] in D:\Coding\serverknights\Satchel\BetterMenus\Utils.cs:82 
[ERROR]:[API] -   at Satchel.BetterMenus.Menu.GetMenuScreen (MenuScreen _returnScreen) [0x00060] in D:\Coding\serverknights\Satchel\BetterMenus\Menu.cs:145 
[ERROR]:[API] -   at HollowKnightAchievementManager.HollowKnightAchievementManager.GetMenuScreen (MenuScreen modListMenu, System.Nullable`1[T] toggleDelegates) [0x00015] in source\src\HollowKnightAchievementManager.cs:104 
[ERROR]:[API] -   at Modding.ModListMenu.<InitMenuCreation>b__3_4 (Modding.Menu.ContentArea c) [0x00413] in <60d0b6c1d8f94e9285cfca026540e40c>:0 

will probably need a fix (and another commit) here in MAPI thanks to Language.Language
nvm, it's on Satchel, but it is thanks to Language.Language

… place, so it can just be created

- no clue what to do with `Language.Language.Get(key)` though
- but that requires all `TeamCherry.Localization.Language` to be done dynamically, via strings, as *all* references to it are replaced, even ones manually written here
@SFGrenade SFGrenade changed the title add changes to make compilable for hk 1.5.12301 add changes to make compilable for hk 1.5.12331 Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant