Vectorize to increase speed of Counter().#199
Open
jdblischak wants to merge 2 commits intohms-dbmi:masterfrom
Open
Vectorize to increase speed of Counter().#199jdblischak wants to merge 2 commits intohms-dbmi:masterfrom
jdblischak wants to merge 2 commits intohms-dbmi:masterfrom
Conversation
Author
|
In one of our analyses with 18 sets, we identified another bottleneck in Lines 50 to 53 in b14854a Vectorizing the above to: decreased the compute time from over 5 minutes to ~5 seconds for our use case. And for consistency, I made the same change to |
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great package. My colleagues and I find UpSet plots very useful.
For one of our larger data sets, we observed that
upset()takes ~5 seconds to complete. After profiling, we found that the following lines contribute the large majority of this compute time (~3 seconds).UpSetR/R/MainBar.R
Lines 29 to 31 in df2151f
In this PR, I converted the above to:
This reduced the runtime of
upset()to ~2 seconds.The results should be identical, but to test I ran the following example code from
?upset:Before:
After: