[fix #81] replace grid.newpage with grid.null#82
Open
fmichonneau wants to merge 1 commit intohms-dbmi:masterfrom
Open
[fix #81] replace grid.newpage with grid.null#82fmichonneau wants to merge 1 commit intohms-dbmi:masterfrom
fmichonneau wants to merge 1 commit intohms-dbmi:masterfrom
Conversation
Using grid.null instead of grid.newpage seems to fix the problem of generating a first blank page when writing files to a PDF graphical device.
Contributor
|
Why does it need grid.null or grid.newpage? Seems to work fine for me just removing the calls to grid.newpage. |
|
I played a bit with |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using grid.null instead of grid.newpage seems to fix the problem of generating a first blank page when writing files to a PDF graphical device.
I'm not a grid specialist and there might be a better approach but this fix solves the issue.