Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curly-berries-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eventkit/http": patch
---

Makes the `@eventkit/base` peer dep optional which silences errors in package managers if it's not being used.
5 changes: 5 additions & 0 deletions .changeset/pretty-items-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eventkit/base": patch
---

The bundle now inlines all types associated with async-observable. This fixes an issue where types would be missing when installing with certain package managers. There may be some conflict for projects that use both `@eventkit/async-observable` and `@eventkit/base` in the same project with this change, but this pattern should be avoided anyways.
13 changes: 10 additions & 3 deletions packages/eventkit-http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,24 @@
},
"./package.json": "./package.json"
},
"peerDependencies": {
"@eventkit/base": "workspace:*"
"dependencies": {
"undici-types": "^7.5.0"
},
"devDependencies": {
"@types/node": "^22.13.14",
"@types/ws": "^8.18.1",
"eventsource": "^3.0.6",
"tsup": "^8.3.6",
"typescript": "^5.7.3",
"undici-types": "^7.5.0",
"wireit": "^0.14.11",
"ws": "^8.18.1"
},
"peerDependencies": {
"@eventkit/base": "workspace:*"
},
"peerDependenciesMeta": {
"@eventkit/base": {
"optional": true
}
}
}
4 changes: 1 addition & 3 deletions packages/eventkit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,8 @@
"NOTICE.md",
"README.md"
],
"dependencies": {
"@eventkit/async-observable": "workspace:*"
},
"devDependencies": {
"@eventkit/async-observable": "workspace:*",
"tsup": "^8.3.6",
"typescript": "^5.7.3",
"wireit": "^0.14.11"
Expand Down
8 changes: 4 additions & 4 deletions packages/eventkit/tsup.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import { defineConfig } from "tsup";
import { createBanner } from "../../scripts/banner";
import pkg from "./package.json";

const banner = createBanner(pkg.name, pkg.version);

export default defineConfig([
{
clean: true,
entry: ["lib/index.ts"],
format: ["cjs", "esm"],
outDir: "dist",
dts: true,
dts: { resolve: true, banner },
noExternal: [/(.*)/],
splitting: false,
banner: {
js: createBanner(pkg.name, pkg.version),
},
banner: { js: banner },
},
]);
Loading