Skip to content

feat: #2254: Add Career Assists and Assists for the Team #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sgcr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: #2254: Add Career Assists and Assists for the Team #2386

sgcr wants to merge 2 commits into from

Conversation

@sgcr
Copy link
Collaborator

@sgcr sgcr commented Jan 15, 2026

  1. changes proposed in this pull request:
  1. src/main/resources/release_notes.md ...
  • has been updated

@sgcr sgcr added this to the 10.0 milestone Jan 15, 2026
@sgcr sgcr self-assigned this Jan 15, 2026
@sgcr sgcr added the effort: moderate Moderate efforts expected and/or limited knowledge of HO required label Jan 15, 2026
@sgcr sgcr requested a review from wsbrenk January 15, 2026 23:06
@sgcr sgcr added the type: enhancement Enhancement label Jan 15, 2026
wsbrenk
wsbrenk requested changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@wsbrenk wsbrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done- but please reset the old translator keys.

@sgcr sgcr force-pushed the feature/2254-career-assists branch from 13db067 to 4cff818 Compare January 17, 2026 01:12
@sgcr sgcr force-pushed the feature/2254-career-assists branch 3 times, most recently from 1e5f2b7 to 431065e Compare January 18, 2026 11:31
@sgcr sgcr requested a review from wsbrenk January 18, 2026 11:46
@sgcr sgcr force-pushed the feature/2254-career-assists branch 2 times, most recently from 9919f30 to 6615afc Compare January 21, 2026 20:22
@sgcr sgcr force-pushed the feature/2254-career-assists branch 2 times, most recently from c372b31 to 61eff2f Compare January 27, 2026 21:49
@sgcr sgcr force-pushed the feature/2254-career-assists branch from 61eff2f to f64adc9 Compare January 27, 2026 21:51
wsbrenk
wsbrenk requested changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@wsbrenk wsbrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want us to annoy each other by claiming other developers' lines of code through reformatting. This also makes reviews unnecessarily time-consuming and increases the risk of merge conflicts.

src/main/java/core/gui/model/PlayerAnalysisModel.java Outdated
columns[62] = additionalArray[20];
columns[63] = additionalArray[23];
columns[64] = additionalArray[24];
columns[51] = goals[4];
Copy link
Collaborator

@wsbrenk wsbrenk Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to the column order disrupts users' tables; please append new table columns with a new ID at the end.

Copy link
Collaborator Author

@sgcr sgcr Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Appended.

@sgcr
Copy link
Collaborator Author

sgcr commented Jan 28, 2026

I don't want us to annoy each other by claiming other developers' lines of code through reformatting. This also makes reviews unnecessarily time-consuming and increases the risk of merge conflicts.

You can use "hide white space" in the diff view of GitHub.

That is the reason I added .editorconfig so that the spaces and tab discussion is clear.

The best solution would be to use a general code formatter (spotless e.g.).

My introduced source code from a year ago is also reformatted in parts switching spaces to tabs and tabs to spaces... ;-)

If you like we can go for spotless?
Should also work for Kotlin.

@sgcr sgcr linked an issue Jan 29, 2026 that may be closed by this pull request
[FEATURE] New chpp feature CareerAssists in player files #2254
Open
@sgcr sgcr requested a review from wsbrenk January 29, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsbrenk wsbrenk Awaiting requested review from wsbrenk

Requested changes must be addressed to merge this pull request.

Assignees

@sgcr sgcr

Labels

effort: moderate Moderate efforts expected and/or limited knowledge of HO required module: Squad type: enhancement Enhancement

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

[FEATURE] New chpp feature CareerAssists in player files

2 participants

@sgcr @wsbrenk