Skip to content

Conversation

@sgcr
Copy link
Collaborator

@sgcr sgcr commented Jan 16, 2026

  1. changes proposed in this pull request:
    Make it possible to use Lombok in Kotlin code.

  2. src/main/resources/release_notes.md ...

  • does not require update

@sgcr sgcr requested a review from wsbrenk January 16, 2026 15:42
@sgcr sgcr self-assigned this Jan 16, 2026
@sgcr sgcr added effort: low Low efforts expected type: code cleaning code update for more clean in code labels Jan 16, 2026
@sgcr sgcr force-pushed the feature/chore-use-lombok-in-kotlin-code branch from ab2f206 to 596e58c Compare January 17, 2026 01:04
@sgcr sgcr force-pushed the feature/chore-use-lombok-in-kotlin-code branch 2 times, most recently from 769277d to d623101 Compare January 17, 2026 13:49
@wsbrenk
Copy link
Collaborator

wsbrenk commented Jan 18, 2026

There are 2 not-so-important points that bother me about the Lombok issue:

  1. That we include additional packages that could lead to vulnerability problems
  2. That its use could result in widespread changes in our source code, making it incredibly difficult for git to produce sane automatic merges without accidents.

Regarding the aspect of Java versus Kotlin, I am very interested in how we can find a way to an Android release, as more and more users are asking for such support. At the moment, apart from this idea, there is neither a concrete roadmap nor a driver.

As I understand, your proposed changes are especially for kotlin code to make the java lomboks usable. As far as we are using lombok, i will accept their usage.

@tychobrailleur
Copy link
Contributor

1. That we include additional packages that could lead to vulnerability problems
2. That its use could result in widespread changes in our source code, making it incredibly difficult for git to produce sane automatic merges without accidents.

As well as polluting git history with a significant number of changes that are only cosmetic in nature. At this point, I feel there is no point in me arguing, so be it.

@sgcr sgcr force-pushed the feature/chore-use-lombok-in-kotlin-code branch from d623101 to 9043c10 Compare January 21, 2026 20:23
@sgcr sgcr force-pushed the feature/chore-use-lombok-in-kotlin-code branch from 9043c10 to c94991b Compare January 27, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort: low Low efforts expected type: code cleaning code update for more clean in code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants