Skip to content

ci: fix NUKE build project warnings #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hojmark merged 1 commit into from
Feb 18, 2026
Merged

ci: fix NUKE build project warnings #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build-utils/Build.Utilities/MsBuild/BinaryLogReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ public static string[] GetWarnings( string binaryLogName ) {
);

return File.ReadAllLines( warningsLogName )
.Select(
.Select( line =>
// Remove the leading " 4>" part
line => Regex.Replace( line, @"^\s*\d+>", string.Empty )
Regex.Replace( line, @"^\s*\d+>", string.Empty )
)
.ToArray();
}
Expand Down
9 changes: 8 additions & 1 deletion build-utils/Build.Utilities/Versioning/ReleaseVersioningBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ IGitHubClient gitHubClient
) {
_repository = repository;
_gitHubClient = gitHubClient;
Repository = repository;
GitHubClient = gitHubClient;

if ( build.ExecutionPlan.Contains( build.Release ) && build.ExecutionPlan.Contains( build.PreRelease ) ) {
throw new InvalidOperationException(
Expand All @@ -40,7 +42,12 @@ IGitHubClient gitHubClient
}
}

[CanBeNull] public IReleaseInfo Release => this;
protected GitRepository Repository { get; }

protected IGitHubClient GitHubClient { get; }

[CanBeNull]
public IReleaseInfo Release => this;

public abstract Task<SemVersion> GetVersionAsync();

Expand Down
6 changes: 3 additions & 3 deletions build-utils/Build.Utilities/Versioning/Strategies/ReleaseVersioning.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ private async Task<SemVersion> GetVersionInternalAsync() {

// TODO can now use .Latest(), since main release is no longer a prerelease
// .Latest() does not return prereleases
var releases = await gitHubClient.Repository.Release.GetAll(
repository.GetGitHubOwner(),
repository.GetGitHubName()
var releases = await GitHubClient.Repository.Release.GetAll(
Repository.GetGitHubOwner(),
Repository.GetGitHubName()
);
var latest = releases
.OrderByDescending( r => r.PublishedAt )
Expand Down
Loading