Increase v6 timeouts and allow changing them#34
Increase v6 timeouts and allow changing them#34ryt51V wants to merge 1 commit intohome-assistant-ecosystem:masterfrom
Conversation
|
Agreed with this change, makes my RPi 1B work in HA (due to API level checks taking over 5 seconds) |
|
Could it also be possible to add a button "retry", in the cases this is not enough? |
|
I think the HA-integration should raise a ConfigEntryNotReady and HA should automatically retry: https://developers.home-assistant.io/docs/integration_setup_failures/ The problem seems to be that when the error happens, it seems lika PH is returning |
If I follow the bug(s) correctly, this is because the initialization has not been finalized before the plugin starts. So GH gives that error, because it probably gets an empty password served. This is two blind threads trying to collaborate. Increasing the time-out will therefore not be the real solution, as it will come back. |
Changes
For connections to Pi-hole v6 instances:
Impact
Notes
I have tested these changes within Home Assistant against a Pi-hole v6 instance running on a Raspberry Pi 1B, which is still technically supported by the Pi-hole project.
Although seemingly trivial, I have not made equivalent changes for v5, as I do not have a Pi-hole v5 instance to test with.