Introduce namespace option in builder.sh#261
Draft
eshattow wants to merge 1 commit intohome-assistant:masterfrom
Draft
Introduce namespace option in builder.sh#261eshattow wants to merge 1 commit intohome-assistant:masterfrom
eshattow wants to merge 1 commit intohome-assistant:masterfrom
Conversation
eshattow
force-pushed
the
buildersh-introduce-namespace-option
branch
2 times, most recently
from
c474920 to
e55b64b
Compare
Added namespace option to builder.sh script overrides namespace of image tag in build.yaml
eshattow
force-pushed
the
buildersh-introduce-namespace-option
branch
from
e55b64b to
e755f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added namespace option to builder.sh script overrides namespace of image tag in build.yaml . This resolves one of the friction points for being able to clone the repo somewhere else on GitHub and run the actions outside of home-assistant org.
Before this is applied it would be needed to to edit the first line of build.yaml for 'image:' to refer to the namespace of the repo.
After this is applied the build.yaml 'image:' gets substituted at runtime whenever github workflow/publish.yml action has the '--namespace ${{ github.repository_owner }}' command line option, making it dynamic and not necessary to manually edit build.yaml