feat: add cli agent choice #23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||
| /** | ||||||
| * Claude CLI adapter | ||||||
| * | ||||||
| * Supports the Anthropic Claude CLI tool | ||||||
| * https://github.com/anthropics/claude-cli | ||||||
| */ | ||||||
|
|
||||||
| import type { CliAdapter, CliAdapterOptions, CliCommandConfig } from './types'; | ||||||
|
|
||||||
| const DEFAULT_MODEL = 'claude-opus-4-20250514'; | ||||||
|
There was a problem hiding this comment. DEFAULT_MODEL needs to be exported from this file since it's imported by cli-adapters/index.ts. Change
Suggested change
Contributor
Author
There was a problem hiding this comment. not applicable any more. |
||||||
|
|
||||||
| export const claudeAdapter: CliAdapter = { | ||||||
| name: 'claude', | ||||||
|
|
||||||
| buildCommand(options: CliAdapterOptions): CliCommandConfig { | ||||||
| const model = options.model ?? DEFAULT_MODEL; | ||||||
|
|
||||||
| return { | ||||||
| command: 'claude', | ||||||
| args: [ | ||||||
| '-p', | ||||||
| '--model', model, | ||||||
| '--dangerously-skip-permissions', | ||||||
| ], | ||||||
| }; | ||||||
| }, | ||||||
| }; | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /** | ||
| * Copilot CLI adapter | ||
| * | ||
| * Supports the GitHub Copilot CLI tool | ||
| */ | ||
|
|
||
| import type { CliAdapter, CliAdapterOptions, CliCommandConfig } from './types'; | ||
|
|
||
| // Default model for the GitHub Copilot CLI; can be overridden via options.model | ||
| const DEFAULT_MODEL = 'gpt-4o'; | ||
|
|
||
| export const copilotAdapter: CliAdapter = { | ||
| name: 'copilot', | ||
|
|
||
| buildCommand(options: CliAdapterOptions): CliCommandConfig { | ||
| const model = options.model ?? DEFAULT_MODEL; | ||
|
|
||
| return { | ||
| command: 'copilot', | ||
| args: [ | ||
| // Note: copilot does not use -p flag | ||
| '--model', model, | ||
| '--allow-all-tools', | ||
| ], | ||
| }; | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /** | ||
| * CLI Adapter factory | ||
| * | ||
| * Registry and factory for CLI adapters | ||
| */ | ||
|
|
||
| import type { CliAdapter } from './types'; | ||
| import { claudeAdapter } from './claude'; | ||
| import { copilotAdapter } from './copilot'; | ||
|
|
||
| // Re-export types | ||
| export type { CliAdapter, CliAdapterOptions, CliCommandConfig } from './types'; | ||
|
|
||
| /** | ||
| * Registry of available CLI adapters | ||
| */ | ||
| const adapters: Map<string, CliAdapter> = new Map([ | ||
| ['claude', claudeAdapter], | ||
| ['copilot', copilotAdapter], | ||
| ]); | ||
|
|
||
| /** | ||
| * List of available CLI tool names (for help text and validation) | ||
| */ | ||
| export const AVAILABLE_CLI_TOOLS = Array.from(adapters.keys()); | ||
|
|
||
| /** | ||
| * Default CLI tool to use | ||
| */ | ||
| export const DEFAULT_CLI_TOOL = 'claude'; | ||
|
|
||
| /** | ||
| * Get a CLI adapter by name | ||
| * | ||
| * @param name - The name of the CLI tool (e.g., 'claude', 'copilot') | ||
| * @returns The CLI adapter | ||
| * @throws Error if the adapter is not found | ||
| */ | ||
| export function getCliAdapter(name: string): CliAdapter { | ||
| const adapter = adapters.get(name); | ||
|
|
||
| if (!adapter) { | ||
| const available = AVAILABLE_CLI_TOOLS.join(', '); | ||
| throw new Error(`Unknown CLI tool: '${name}'. Available tools: ${available}`); | ||
| } | ||
|
|
||
| return adapter; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /** | ||
| * CLI Adapter types for supporting multiple AI CLI tools | ||
| */ | ||
|
|
||
| /** | ||
| * Options passed to the adapter when building the command | ||
| */ | ||
| export interface CliAdapterOptions { | ||
| model?: string; | ||
| } | ||
|
|
||
| /** | ||
| * The command configuration returned by an adapter | ||
| */ | ||
| export interface CliCommandConfig { | ||
| command: string; | ||
| args: string[]; | ||
| } | ||
|
|
||
| /** | ||
| * Interface that all CLI adapters must implement | ||
| */ | ||
| export interface CliAdapter { | ||
| /** Unique identifier for this CLI tool */ | ||
| name: string; | ||
|
|
||
| /** Build the command and arguments for executing the CLI */ | ||
| buildCommand(options: CliAdapterOptions): CliCommandConfig; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help text states 'defaults to CLI tool's default model', but doesn't indicate what those defaults are. Consider mentioning that Claude defaults to 'claude-opus-4-20250514' and Copilot to 'gpt-4o', or link to documentation where users can find this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can assume folks know how to find the model for their given CLI.