Solving issue #19 feat: improve existing button components#21
Open
The-x-35 wants to merge 2 commits intohoppscotch:mainfrom
Open
Solving issue #19 feat: improve existing button components#21The-x-35 wants to merge 2 commits intohoppscotch:mainfrom
The-x-35 wants to merge 2 commits intohoppscotch:mainfrom
Conversation
…ted their all instances in the code to fit the new use case, also edited the readme for the new button component
anwarulislam
requested changes
Aug 13, 2024
Author
|
How will I achieve that sir ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I solved the issue #19 . Combined primary and secondary button into a single component and edited their all instances in the code to fit the new use case, also edited the readme for the new button component. I have tested the code and also tested all the instances where the button was being used and they all work perfectly.