Update getSearchResults() to use Search_Params/Results objects and fix several bugs#61
Merged
amulet1 merged 1 commit intohorde:FRAMEWORK_6_0from Mar 11, 2026
Merged
Conversation
…ts objects and fix several bugs - Update getSearchResults() signature to accept Search_Params and return Search_Results, matching the base class refactor - Move pagination (start/limit) and total count back to getSearchResults() - Update _searchMailbox() and _searchGal() signatures to accept separate $options and $deepTraversal parameters instead of a flat $query array - Move ob_start()/endBuffer() into getSearchResults() from _searchGal() - Fix Horde_ActiveSync_Exeption_StaleState typo (missing 'c') - Fix $e->getMessage missing parentheses in CLASS_TASKS and CLASS_NOTES exception handlers in getMessage() — was accessing a non-existent property instead of calling the method, resulting in null message strings - Fix $event->creator undefined variable in meetingResponse() - Fix $fowardees typo in sendMail() — was assigned but never used - Mark $organizer and $cn as unused with FIXME/comment - Fix 'stirng' docblock typo in _buildNonMailFolder()
ralflang
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSearchResults()signature to acceptSearch_Paramsand returnSearch_Results, matching the base class refactorgetSearchResults()_searchMailbox()and_searchGal()signatures to accept separate$optionsand$deepTraversalparameters instead of a flat$queryarrayob_start()/endBuffer()into getSearchResults() from_searchGal()Horde_ActiveSync_Exeption_StaleStatetypo (missing 'c')$e->getMessagemissing parentheses in CLASS_TASKS and CLASS_NOTES exception handlers ingetMessage()$event->creatorundefined variable inmeetingResponse()$fowardeestypo insendMail()— was assigned but never used$organizerand$cnas unused with FIXME/comment_buildNonMailFolder()See #56 also.
IMPORTANT: Requires changes in horde/ActiveSync#13.