Merged
Conversation
…ent::__construct() Extract connector, auth, imap and cache from $params before calling parent::__construct(), consolidating the repeated extract-and-unset pattern into a private helper method.
Use strict null comparison for $_mailFolders cache check, build folders into a local variable before assigning, simplify the code.
ralflang
approved these changes
Mar 16, 2026
Member
|
Do you want a new tagged release tonight? @amulet1 |
Contributor
Author
|
Up to you - no real need, as these are mostly deprecation fixes in old code and minor improvements. Except for explode() call on object, which is a fatal error (but it was always there, and I have yet to find a way to trigger that part of the code). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes and refactoring