Use the backend's native modify timestamp if available#4
Open
ralflang wants to merge 1 commit intohorde:masterfrom
Open
Use the backend's native modify timestamp if available#4ralflang wants to merge 1 commit intohorde:masterfrom
ralflang wants to merge 1 commit intohorde:masterfrom
Conversation
Member
|
I see an issue with the fact that the synchronization related API calls ...and yes, I know how long it's been since this was opened :) Better late than never. |
Member
Author
|
Good points though Michael. I will need to consult with colleagues how to avoid this gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the backend to provide own modification timestamps.
The main target is the turba ldap driver, but implementation is driver agnostic. There are two use cases:
Both cases result in the same behavior:
This feature is opt-in, the code change will not modify existing installations without further config.
The administrator has to actively configure a __nativemodified attribute to benefit from backend's info.
If present and not null, the backend's info will be used and the history API will not be queried or updated.
One could get almost the same effect by just mapping a __modified attribute to "modifytimestamp". However, modifytimestamp is in a string format, while turba's lastModification method is documented as returning an integer timestamp.