Cast "threshold" from Int type to long type#139
Cast "threshold" from Int type to long type#139yuna-yano wants to merge 2 commits intohotchemi:masterfrom
Conversation
| @@ -54,7 +54,7 @@ public static boolean showRateDialogIfMeetsConditions(Activity activity) { | |||
| } | |||
|
|
|||
| private static boolean isOverDate(long targetDate, int threshold) { | |||
There was a problem hiding this comment.
I guess changing the type of second argument as long is simpler solution, what do you think?
There was a problem hiding this comment.
Thank you for review.
That's good! I will fix that way.
yuna-yano
force-pushed
the
threshold_cast_to_long
branch
from
4e55df6 to
2fbebcd
Compare
|
Thx and LGTM! Let me look into CI. |
|
@yuna-yano your commits were merged into https://github.com/Vorlonsoft/AndroidRate/ (Releases 1.0.9+) |
|
@hotchemi
When searching, Issue like this came out. I think this is a problem of the CI environment. It is another repository, but for reference. Thank you. |
3 participants
It corresponds to issue #138.