fix: reject degenerate polygons in AOI area validation#465
Open
heathdutton wants to merge 1 commit intohotosm:developfrom
Open
fix: reject degenerate polygons in AOI area validation#465heathdutton wants to merge 1 commit intohotosm:developfrom
heathdutton wants to merge 1 commit intohotosm:developfrom
Conversation
Member
|
Thanks @heathdutton for the PR , we will be reviewing this soon ! |
Collaborator
|
Thank you for your contribution @heathdutton . The issue this PR intends to fix was happening before the latest development on fAIr. As of now, you can't experience the bug again because we now have a minimum size for drawing a polygon. See attached video for context. Screen.Recording.2026-01-18.at.17.22.34.movNevertheless, we'll have this PR opened for merging should such issue come up again in the future. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228
When drawing an AOI at low zoom levels, the polygon coordinates can collapse to nearly identical points, resulting in a degenerate polygon with zero area. The
validateGeoJSONAreafunction was incorrectly returningfalse(valid) for these cases instead oftrue(invalid). Confused? So was I.This one-line fix correctly rejects polygons with zero, NaN, or invalid area values.