HPCC-33560 Reuse the compressor when building hybrid indexes

[ghalliday]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33560

Jirabot Action Result:
Assigning user: gavin.halliday@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Updated PR

[ghalliday]

First commit is part of a separate PR.

[Copilot]

Pull request overview

This PR refactors the hybrid index compression implementation to reuse compressor instances instead of creating new ones for each node, improving efficiency during index building. The changes consolidate the HybridIndexCompressor class into the jhblockcompressed module and eliminate the redundant BlockCompressedIndexCompressor class.

Key Changes:

• Moved HybridIndexCompressor from keybuild.cpp to jhblockcompressed.hpp/cpp for better code organization
• Modified CBlockCompressedBuildContext to store and initialize a reusable ICompressor instance
• Updated CBlockCompressedWriteNode to use the shared compressor instead of creating new instances

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
system/jhtree/keybuild.cpp	Removed HybridIndexCompressor class definition (moved to jhblockcompressed module)
system/jhtree/jhblockcompressed.hpp	Added jhinplace.hpp include, modified CBlockCompressedBuildContext to support compressor reuse, and moved HybridIndexCompressor here
system/jhtree/jhblockcompressed.cpp	Implemented compressor reuse by storing a single ICompressor in CBlockCompressedBuildContext and moved/refactored HybridIndexCompressor implementation

[Copilot]

The struct has two consecutive public access specifiers. The first public label at line 84 is redundant and should be removed, as structs have public access by default and there's another public label immediately following at line 87.

Suggested change

public: