Escape dollars in names to prevent env-var expansion#117
Closed
joshbode wants to merge 1 commit intohrsh7th:mainfrom
Closed
Escape dollars in names to prevent env-var expansion#117joshbode wants to merge 1 commit intohrsh7th:mainfrom
joshbode wants to merge 1 commit intohrsh7th:mainfrom
Conversation
|
Better to escape other special chars, e.g. |
joshbode
force-pushed
the
escape-dollar
branch
from
9e35c23 to
3f7307c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dollars in filenames need to be escaped so they aren't interpreted as variables for expansion
Having
$in filenames is something that is common in Remix (dynamic segments)