fix: remove redundant UIEnter subscription#2165
Open
crackcomm wants to merge 1 commit intohrsh7th:mainfrom
Open
fix: remove redundant UIEnter subscription#2165crackcomm wants to merge 1 commit intohrsh7th:mainfrom
crackcomm wants to merge 1 commit intohrsh7th:mainfrom
Conversation
The UIEnter event is not needed for setting up the highlight groups in cmp.lua. This caused a bug displaying ANSI escape sequences in neovim in tmux, kitty, and alacritty. I found this bug after 2 days of debugging, searching for the cause in the wrong place - zsh, tmux, kitty, then testing on alacritty and xterm, and finally realizing that the issue was in the Neovim configuration itself. If this does not in fact fix the issue, even though I tested it thoroughly, it is still a redundant call in my opinion, especially since `ColorScheme` event is immediately triggered after the subscription.
Author
|
I notice that it is a fix for #1649, maybe it's appropriate to keep this functionality for |
Collaborator
|
neovim supports maybe you can check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UIEnter event is not needed for setting up the highlight groups in cmp.lua.
This caused a bug displaying ANSI escape sequences in neovim in tmux, kitty, and alacritty.
I found this bug after 2 days of debugging, searching for the cause in the wrong place - zsh, tmux, kitty, then testing on alacritty and xterm, and finally realizing that the issue was in the Neovim configuration itself.
If this does not in fact fix the issue, even though I tested it thoroughly, it is still a redundant call in my opinion, especially since
ColorSchemeevent is immediately triggered after the subscription.