-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat!: astro frontend #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gildesmarais
wants to merge
48
commits into
master
Choose a base branch
from
feat/revamp-frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+16,354
−3,632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cd0291 to
26085bf
Compare
26085bf to
a58186e
Compare
- Deleted test scripts for auto-source and URL restrictions as they are no longer needed. - Removed unused dependencies from package.json and package-lock.json to streamline the project. - Updated the dev script to improve clarity in error messages regarding port conflicts.
Signed-off-by: Gil Desmarais <git@desmarais.de>
…ce, HealthCheck, HttpCache, LocalConfig, RackAttack, SecurityLogger, SsrfFilterStrategy, and XmlBuilder. These tests are no longer relevant to the current implementation.
- Simplified the auto source configuration in CONFIGURATION.md. - Removed obsolete allowed origin checks from feeds.rb. - Updated session storage usage in frontend tests and hooks. - Enhanced error handling for unsupported strategies in API endpoints. - Improved rate limiting responses in rack_attack.rb.
d0c9235 to
4b2b917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explorative Work / In Progress
TODOs
This pull request introduces a comprehensive modernization and restructuring of the development environment, build pipeline, and documentation to support a hybrid Ruby (Roda) backend and Astro frontend architecture. It adds full frontend tooling and CI integration, improves developer experience, and updates documentation and configuration to reflect the new stack.
Development & Build Environment Modernization:
Devcontainer & Docker Compose:
.devcontainer/Dockerfileanddocker-compose.ymlto support local development with both Ruby and Node.js, replacing the previous image-based setup. The devcontainer now exposes both backend (3000) and frontend (4321) ports and uses a dedicated workspace folder. (.devcontainer/Dockerfile[1].devcontainer/devcontainer.json[2].devcontainer/docker-compose.yml[3]Dockerfileto use a multi-stage build: first building the Astro frontend, then the Ruby app, and finally copying the built frontend assets into the production image. Healthcheck and environment variables were updated for the new API structure. (Dockerfile[1] [2] [3]Tooling & Configuration:
.tool-versionsto specify Ruby 3.4.6 and Node.js 22.19.0 for consistent environment setup. (.tool-versions.tool-versionsR1-R2).rubocop.ymlfor new RuboCop plugin syntax, excluded YAML and config files, and disabled documentation enforcement. (.rubocop.yml[1] [2] [3].vscode/extensions.json[1].vscode/settings.json[2]Gemfileto pin Ruby and html2rss versions and move some gems to development-only. (GemfileGemfileL8-R32).yardoptsfor improved YARD documentation generation. (.yardopts.yardoptsR1-R10).ruby-versionin favor of.tool-versions. (.ruby-version.ruby-versionL1)CI/CD Pipeline Overhaul:
.github/workflows/ci.ymlthat runs on push, PR, and manual dispatch, with concurrency control. It now includes:.github/workflows/ci.yml[1] [2] [3].github/workflows/bundle-update.yml.github/workflows/bundle-update.ymlL1-L17)Developer Experience & Documentation:
Makefile Enhancements:
Makefile[1] [2]Documentation Updates:
.github/copilot-instructions.mdto document the new Astro frontend, clarify project structure, and add links to core dependency docs. Added explicit "do" and "don't" rules for both backend and frontend development, and included verification steps for local development. (.github/copilot-instructions.md[1] [2]Most Important Changes:
Development Environment & Tooling
.devcontainer/Dockerfile[1].devcontainer/devcontainer.json[2].devcontainer/docker-compose.yml[3].tool-versionsto standardize Ruby and Node.js versions across environments. (.tool-versions.tool-versionsR1-R2)Makefile[1] [2]Build & CI/CD Pipeline
Dockerfile[1] [2] [3].github/workflows/ci.yml[1] [2] [3]Documentation & Coding Standards
.github/copilot-instructions.md[1] [2].rubocop.yml[1] [2] [3].vscode/extensions.json[1].vscode/settings.json[2]