Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Feb 2, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/sonarqube-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins Backstage dependencies to specific versions in the SonarQube backend plugin, replacing workspace protocol references.

  • Changed @backstage/backend-common from workspace:^ to version 0.24.1
  • Changed @backstage/errors from workspace:^ to version 0.1.1
  • Transitions from monorepo workspace dependencies to fixed version specifications
  • Enables reproducible builds and prepares package for potential independent publication

@codesandbox
Copy link

codesandbox bot commented Feb 2, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two identified vulnerabilities. It achieves this by updating specific package dependencies within the plugins/sonarqube-backend/package.json file to their patched versions, ensuring the project benefits from the latest security fixes.

Highlights

  • Security Vulnerability Fixes: This PR addresses two medium-severity vulnerabilities: "Directory Traversal" (SNYK-JS-TAR-15127355) and "Uncontrolled Recursion" (SNYK-JS-ESLINT-15102420), identified by Snyk.
  • Dependency Version Upgrades: To resolve the vulnerabilities, the @backstage/backend-common dependency has been upgraded to version 0.24.1 and @backstage/errors to 0.1.1 in plugins/sonarqube-backend/package.json.
Changelog
  • plugins/sonarqube-backend/package.json
    • Updated @backstage/backend-common dependency from workspace:^ to 0.24.1.
    • Updated @backstage/errors dependency from workspace:^ to 0.1.1.
Activity
  • This pull request was automatically created by Snyk to propose fixes for identified vulnerabilities.
  • A warning was issued indicating that the yarn.lock file failed to update and requires manual intervention before merging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Feb 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates the dependency management strategy for the SonarQube backend plugin by replacing workspace protocol references with fixed version numbers. Specifically, two Backstage dependencies (@backstage/backend-common and @backstage/errors) are pinned to versions 0.24.1 and 0.1.1 respectively. This change transitions from monorepo workspace-based dependency resolution to explicit version pinning, which is typically done when preparing a package for independent publication or when moving away from a monorepo structure. The modification ensures reproducible builds with specific dependency versions rather than relying on workspace resolution.

Changes

File(s) Summary
plugins/sonarqube-backend/package.json Replaced workspace protocol (workspace:^) with fixed versions for @backstage/backend-common (0.24.1) and @backstage/errors (0.1.1) dependencies.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Registry as NPM Registry
    
    Note over Dev,Registry: Dependency Version Update Process
    
    Dev->>PM: Update package.json<br/>(lock backend-common to 0.24.1<br/>lock errors to 0.1.1)
    
    activate PM
    PM->>Registry: Resolve @backstage/backend-common@0.24.1
    Registry-->>PM: Return package metadata
    
    PM->>Registry: Resolve @backstage/errors@0.1.1
    Registry-->>PM: Return package metadata
    
    PM->>PM: Update lock file with<br/>specific versions
    deactivate PM
    
    PM-->>Dev: Dependencies resolved<br/>and locked to versions
    
    Note over Dev,Registry: No runtime behavior changes<br/>Only dependency version locking
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. While the intent is correct, the implementation has a couple of significant issues that need to be addressed before merging.

Firstly, as noted in the PR description, the yarn.lock file has not been updated. This is a critical step and the PR is incomplete without it. You will need to run yarn install to regenerate the lockfile.

Secondly, the approach of pinning @backstage/backend-common and @backstage/errors to specific versions instead of using workspace:^ is an anti-pattern in this monorepo. It breaks the local workspace linking, causing these packages to be fetched from the npm registry instead of using the local source code. This can lead to inconsistencies and make local development difficult.

I've left a comment with a suggestion to revert this change and a recommendation for the correct approach, which involves updating the vulnerable transitive dependencies in their respective workspace packages.

Comment on lines +25 to +27
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning workspace dependencies to specific versions like this is an anti-pattern in a monorepo using Yarn workspaces. It breaks the link to the local packages and instead fetches them from the registry, which can lead to inconsistencies and problems during development.

The correct approach to fix these vulnerabilities is to:

  1. Identify which workspace package has the vulnerable transitive dependency (e.g., @backstage/backend-common seems to have a vulnerable version of tar).
  2. Update the dependency within that package's package.json.
  3. Run yarn install at the root to update the yarn.lock file.
  4. Revert the changes in this file to use workspace:^ again.

This will ensure the vulnerabilities are fixed across the monorepo without breaking the workspace setup.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants