Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/ilert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a workspace dependency with a pinned, older version. In a monorepo setup like this one, packages should use "workspace:^" to refer to other packages within the same repository. This ensures version consistency and that all plugins use the most up-to-date code from the workspace.

Pinning @backstage/theme to 0.1.1 is a significant downgrade from the current workspace version (0.4.1) and will likely cause dependency conflicts, duplicate modules, and runtime errors. This breaks the project's intended dependency management strategy.

The correct approach to fix vulnerabilities would be to address them within the @backstage/theme package itself, not by pinning a dependency in a consuming package. This automated change should be rejected.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@date-io/luxon": "1.x",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading