[Snyk] Fix for 2 vulnerabilities #11646
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading several Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, attempts to fix two vulnerabilities by modifying dependencies in plugins/permission-react/package.json. However, the proposed changes are incorrect and will likely break the application. The PR downgrades several core @backstage packages to very old versions and removes the workspace:^ protocol, which is essential for this monorepo setup. These changes are highly likely to introduce breaking changes and build failures. Additionally, as noted in the PR description, the yarn.lock file has not been updated, which is another critical issue. I have left a comment with a suggestion to revert the changes and use yarn's resolutions feature to fix the transitive dependency vulnerabilities instead, which is a safer approach.
| "@backstage/config": "0.1.1", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/plugin-permission-common": "0.1.0", |
There was a problem hiding this comment.
These changes introduce significant downgrades to several @backstage dependencies and remove the workspace:^ protocol. This will likely break the package as it decouples it from the monorepo's versioning scheme. The versions are being downgraded from what's in the workspace (e.g., @backstage/config@1.0.8, @backstage/core-plugin-api@1.5.3) to very old versions (0.1.1, 0.1.0). This is a destructive change that will almost certainly cause build failures and runtime errors due to API incompatibilities.
Instead of these changes, consider reverting to workspace:^ and addressing the transitive dependency vulnerabilities (in tar and eslint) by adding a resolutions field to the root package.json to force newer, non-vulnerable versions of those packages.
"@backstage/config": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant PR as "permission-react Plugin"
participant Config as "@backstage/config"
participant CoreAPI as "@backstage/core-plugin-api"
participant PermCommon as "@backstage/plugin-permission-common"
Note over PR: Dependency Version Update
Note over PR,PermCommon: Changed from workspace:^ to fixed versions
PR->>Config: Depends on v0.1.1 (was workspace:^)
PR->>CoreAPI: Depends on v0.1.0 (was workspace:^)
PR->>PermCommon: Depends on v0.1.0 (was workspace:^)
Note over PR,PermCommon: No functional code changes<br/>Package configuration only
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/permission-react/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR transitions the permission-react plugin from workspace protocol dependencies to pinned version numbers for Backstage packages.
@backstage/configdependency to explicit version 0.1.1@backstage/core-plugin-apidependency to explicit version 0.1.0@backstage/plugin-permission-commondependency to explicit version 0.1.0