Skip to content

[Snyk] Fix for 2 vulnerabilities #11647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #11647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/user-settings-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +32 to +36
Copy link

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ dependencies with pinned versions. In a monorepo setup like this one (using Yarn workspaces), this will cause the project to download these packages from the npm registry instead of using the local versions from this repository. This can lead to build failures, inconsistencies between packages, and makes local development very difficult.

Additionally, the pull request description notes that yarn.lock has not been updated, which is a critical omission for any dependency change.

The correct approach to fix these vulnerabilities is to either:

  1. Update the source package within the monorepo that has the vulnerability.
  2. Use Yarn's resolutions field in the root package.json to force a non-vulnerable version of the transitive dependency (e.g., tar or eslint).

After applying the correct fix, you must run yarn to update the yarn.lock file accordingly. I suggest reverting these changes and applying a proper fix.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^"

"@backstage/types": "workspace:^",
"@types/express": "^4.17.6",
"express": "^4.17.1",
Expand Down
Loading