Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/microsoft-calendar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from workspace:^ to a pinned version 0.1.1 is incorrect for this monorepo setup. Using workspace:^ ensures that this package uses the version of @backstage/theme from this repository, which is currently 0.4.1.

Pinning to 0.1.1 is a significant downgrade and will cause this package to fetch an old version from the npm registry instead of using the local one. This can lead to dependency conflicts and runtime issues, as other packages like @backstage/core-components will be using the 0.4.1 version from the workspace.

It's recommended to revert this change. If there are vulnerabilities in @backstage/theme, they should be addressed within the @backstage/theme package itself, not by pinning to an old version in a consuming package.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@microsoft/microsoft-graph-types": "^2.25.0",
Expand Down
Loading