Skip to content

[Snyk] Fix for 2 vulnerabilities #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #11649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@
"backstage-cli": "bin/backstage-cli"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/eslint-plugin": "0.1.0",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
Comment on lines +33 to +41
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing these @backstage dependencies from workspace:^ to pinned versions is problematic in a monorepo. It will cause these packages to be fetched from the npm registry instead of being linked from the local source code. This can lead to using outdated code and breaks the purpose of yarn workspaces. These changes should be reverted to use workspace:^.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/cli-common": "workspace:^",
    "@backstage/cli-node": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/config-loader": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/eslint-plugin": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/release-manifests": "workspace:^"

"@backstage/types": "workspace:^",
"@esbuild-kit/cjs-loader": "^2.4.1",
"@manypkg/get-packages": "^1.1.3",
Expand Down Expand Up @@ -80,7 +80,7 @@
"diff": "^5.0.0",
"esbuild": "^0.18.0",
"esbuild-loader": "^2.18.0",
"eslint": "^8.6.0",
"eslint": "^9.26.0",
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading eslint from v8 to v9 is a major version bump that may introduce breaking changes. It's important to verify that all related ESLint plugins and configurations (e.g., eslint-plugin-*, @typescript-eslint/*) are compatible with ESLint v9 and that the linting process still works as expected. You may need to update other dependencies as well.

"eslint-config-prettier": "^8.3.0",
"eslint-formatter-friendly": "^7.0.0",
"eslint-plugin-deprecation": "^1.3.2",
Expand Down Expand Up @@ -127,7 +127,7 @@
"style-loader": "^3.3.1",
"sucrase": "^3.20.2",
"swc-loader": "^0.2.3",
"tar": "^6.1.12",
"tar": "^7.5.7",
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a major version upgrade for tar (from v6 to v7). While this fixes a security vulnerability, it's important to ensure that there are no breaking changes affecting how this package is used within the project.

"terser-webpack-plugin": "^5.1.3",
"util": "^0.12.3",
"webpack": "^5.70.0",
Expand Down
Loading