-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #11650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving critical vulnerabilities. It achieves this by updating specific Backstage dependencies within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
WalkthroughThis PR updates the dependency management strategy for the todo-backend plugin by replacing workspace protocol references with specific pinned versions. Four Backstage dependencies are affected: backend-common (0.24.1), catalog-client (0.2.0), catalog-model (0.1.1), and plugin-catalog-node (1.0.0). This transition from monorepo workspace dependencies to explicit published package versions suggests preparation for standalone plugin distribution or enforcement of version consistency across different deployment environments. The change ensures reproducible builds and eliminates reliance on workspace-specific dependency resolution. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant TB as todo-backend Plugin
participant BC as @backstage/backend-common
participant CC as @backstage/catalog-client
participant CM as @backstage/catalog-model
participant CN as @backstage/plugin-catalog-node
Note over Dev,CN: Dependency Version Pinning Update
Dev->>PM: Update package.json dependencies
Note right of PM: Change workspace:^ to<br/>specific versions
PM->>TB: Install dependencies
TB->>BC: Require v0.24.1 (pinned)
Note right of BC: Previously: workspace:^
BC-->>TB: Backend utilities available
TB->>CC: Require v0.2.0 (pinned)
Note right of CC: Previously: workspace:^
CC-->>TB: Catalog client available
TB->>CM: Require v0.1.1 (pinned)
Note right of CM: Previously: workspace:^
CM-->>TB: Catalog models available
TB->>CN: Require v1.0.0 (pinned)
Note right of CN: Previously: workspace:^
CN-->>TB: Catalog node utilities available
PM-->>Dev: Dependencies resolved and installed
Note over Dev,CN: All dependencies now use<br/>fixed versions instead of<br/>workspace references
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the plugins/todo-backend/package.json file, specifically changing several @backstage dependency versions from workspace:^ to fixed versions. Affected dependencies include @backstage/backend-common (to 0.24.1), @backstage/catalog-client (to 0.2.0), @backstage/catalog-model (to 0.1.1), and @backstage/plugin-catalog-node (to 1.0.0). There are no review comments provided for this change.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/todo-backend/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
Updated todo-backend plugin dependencies from workspace protocol to pinned versions for standalone distribution compatibility.
@backstage/backend-commonfromworkspace:^to version0.24.1@backstage/catalog-clientfromworkspace:^to version0.2.0@backstage/catalog-modelfromworkspace:^to version0.1.1@backstage/plugin-catalog-nodefromworkspace:^to version1.0.0