-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #11652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security by resolving two critical vulnerabilities. It achieves this by upgrading specific Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis PR updates the dependency management strategy for the proxy-backend plugin by replacing workspace protocol references with fixed version numbers for two Backstage packages. The Changes
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk attempts to fix security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup and are likely to cause critical failures. The PR pins versions for @backstage/backend-common and @backstage/config, which breaks the workspace: protocol. Most critically, it severely downgrades @backstage/config, which will almost certainly break the application. I have added a critical review comment explaining why this PR should be rejected and suggested reverting the changes. The vulnerabilities should be addressed manually within the monorepo's structure.
| "@backstage/backend-common": "0.24.1", | ||
| "@backstage/backend-plugin-api": "workspace:^", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/config": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated change from Snyk is incorrect and will likely break the application. It should not be merged.
The main issues are:
- Breaking Monorepo Structure: It replaces
workspace:^with pinned versions. This goes against the monorepo's dependency strategy and can cause version conflicts. - Dangerous Version Changes:
@backstage/configis being severely downgraded from1.0.8to0.1.1, which is a critical issue.@backstage/backend-commonis being significantly upgraded, which introduces a high risk of breaking changes.
The correct way to fix the security vulnerabilities is to update the dependencies within their respective packages in the workspace, not to pin them here.
| "@backstage/backend-common": "0.24.1", | |
| "@backstage/backend-plugin-api": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/config": "0.1.1", | |
| "@backstage/backend-common": "workspace:^", | |
| "@backstage/backend-plugin-api": "workspace:^", | |
| "@backstage/config": "workspace:^", |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/proxy-backend/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR pins Backstage dependencies to specific versions in the proxy-backend plugin, replacing workspace protocol references.
@backstage/backend-commonfromworkspace:^to fixed version0.24.1@backstage/configfromworkspace:^to fixed version0.1.1plugins/proxy-backend/package.json