-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/types from 0.0.0-use.local to 0.1.1 #11653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update for a core dependency, enhancing the project's overall security posture by resolving known vulnerabilities. The change involves a targeted package version bump to mitigate potential risks without introducing broader functional modifications. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis PR updates the dependency management for the search-react plugin by pinning the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant PM as Package Manager
participant SR as search-react Plugin
participant WS as Workspace
participant NPM as NPM Registry
Note over PM,NPM: Dependency Resolution Change
PM->>SR: Read package.json
SR-->>PM: Dependencies list
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/types
WS-->>PM: Local workspace version
else After Change (0.1.1)
PM->>NPM: Fetch @backstage/types@0.1.1
NPM-->>PM: Package version 0.1.1
end
PM->>SR: Install resolved dependency
Note over SR: search-react now uses<br/>@backstage/types@0.1.1<br/>from NPM registry
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading the @backstage/types dependency. However, the proposed change from workspace:^ to a pinned version 0.1.1 is incorrect for this monorepo setup. It constitutes a significant downgrade from the local version (1.1.0) and breaks the workspace integrity, which will likely cause build failures. I have left a critical comment suggesting to revert this change. The security vulnerabilities should be addressed by updating the dependencies within the @backstage/types package itself.
| "@backstage/plugin-search-common": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/types": "workspace:^", | ||
| "@backstage/types": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated change incorrectly replaces the monorepo workspace:^ protocol with a pinned version from the npm registry. This is a significant issue for several reasons:
- Breaks Monorepo Integrity: It decouples this package from the local
@backstage/typespackage, defeating the purpose of the monorepo setup. Changes made to@backstage/typeslocally will no longer be picked up. - Significant Downgrade: The version is pinned to
0.1.1, while the version of@backstage/typeswithin this monorepo is1.1.0(as seen inpackages/types/package.json). This is a major downgrade and will almost certainly lead to compilation errors or runtime issues due to API incompatibilities. - Incorrect Fix Strategy: The underlying security vulnerabilities should be addressed by updating the dependencies of the
@backstage/typespackage itself, not by pinning a dependent package to an old, arbitrary version.
This change should be reverted to maintain the integrity of the workspace. The security vulnerabilities need to be addressed at their source.
"@backstage/types": "workspace:^"
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/search-react/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR pins the
@backstage/typesdependency to version 0.1.1 in the search-react plugin for improved stability and compatibility.workspace:^) with fixed version (0.1.1)plugins/search-react/package.json