Skip to content

[Snyk] Fix for 2 vulnerabilities #11654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #11654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-backend-module-rails/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "2.1.0",
"@backstage/plugin-scaffolder-node": "0.2.0",
Comment on lines +26 to +31
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning these Backstage dependencies to specific versions breaks the Yarn workspace setup. The workspace:^ protocol ensures that local packages from the monorepo are used, which is crucial for development and consistency. By changing this, you are forcing Yarn to download these packages from the registry, which can lead to version conflicts and ignore local changes.

To fix the Snyk vulnerabilities correctly, you should identify which transitive dependency is vulnerable and update it within the appropriate Backstage package, or update the versions of the workspace packages themselves across the monorepo while retaining the workspace:^ references.

The PR description also warns that yarn.lock could not be updated, which is a strong signal that these changes are problematic. Please revert this and address the vulnerability at its source.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-scaffolder-backend": "workspace:^",
    "@backstage/plugin-scaffolder-node": "workspace:^"

"@backstage/types": "workspace:^",
"command-exists": "^1.2.9",
"fs-extra": "^10.0.1"
Expand Down
Loading