Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Feb 3, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/config-loader/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins internal Backstage dependencies to specific versions in the config-loader package.

  • Changed @backstage/errors from workspace:^ to 0.1.1
  • Changed @backstage/types from workspace:^ to 0.1.1
  • Replaces workspace protocol with fixed version constraints
  • Modified in packages/config-loader/package.json

@codesandbox
Copy link

codesandbox bot commented Feb 3, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by addressing two identified medium-severity vulnerabilities. The core change involves updating specific dependency versions within packages/config-loader/package.json. Reviewers should note the explicit requirement for a manual yarn.lock update and the implications for Yarn zero-install users.

Highlights

  • Vulnerability Resolution: This PR, automatically generated by Snyk, addresses two medium-severity vulnerabilities: a Directory Traversal issue (SNYK-JS-TAR-15127355) and an Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420).
  • Dependency Version Bumping: The packages/config-loader/package.json file has been updated to explicitly set the versions of @backstage/errors and @backstage/types to 0.1.1, moving away from workspace:^ references.
  • Manual yarn.lock Update Required: The automated process failed to update the yarn.lock file, which will require manual intervention before merging this pull request.
  • Zero-Install Considerations: Users leveraging Yarn's zero-installs feature will need to run yarn locally to update their .yarn/cache/ directory, as this PR does not include those changes.
Changelog
  • packages/config-loader/package.json
    • Updated @backstage/errors dependency from workspace:^ to 0.1.1.
    • Updated @backstage/types dependency from workspace:^ to 0.1.1.
Activity
  • This pull request was automatically created by Snyk to fix identified security vulnerabilities.
  • The PR description provides details on the two medium-severity vulnerabilities being addressed.
  • A warning is included regarding the failure to update yarn.lock, requiring manual action.
  • Guidance is provided for users of Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Feb 3, 2026

Snyk checks have failed. 5 issues have been found so far.

Status Scanner Critical High Medium Low Total (5)
Open Source Security 0 4 1 0 5 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management strategy for the @backstage/config-loader package by replacing workspace protocol references with pinned version numbers. Specifically, two internal Backstage dependencies (@backstage/errors and @backstage/types) are changed from using the flexible workspace protocol (workspace:^) to fixed version 0.1.1. This change indicates a transition from local workspace dependency resolution to explicit published package versions, which typically occurs when preparing a package for publication or addressing dependency resolution challenges within a monorepo environment.

Changes

File(s) Summary
packages/config-loader/package.json Updated @backstage/errors and @backstage/types dependencies from workspace:^ to pinned version 0.1.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace
    participant NPM as NPM Registry
    participant CL as config-loader

    Dev->>PM: Install dependencies for config-loader
    
    Note over PM,CL: Before: workspace:^ references
    PM->>WS: Resolve @backstage/errors (workspace:^)
    WS-->>PM: Return local workspace version
    PM->>WS: Resolve @backstage/types (workspace:^)
    WS-->>PM: Return local workspace version
    
    Note over PM,CL: After: Fixed version 0.1.1
    PM->>NPM: Fetch @backstage/errors@0.1.1
    NPM-->>PM: Return package version 0.1.1
    PM->>NPM: Fetch @backstage/types@0.1.1
    NPM-->>PM: Return package version 0.1.1
    
    PM->>CL: Install resolved dependencies
    CL-->>Dev: Dependencies installed
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request, generated by Snyk, aims to address two vulnerabilities by updating dependencies. However, the proposed changes in packages/config-loader/package.json involve downgrading @backstage/errors and @backstage/types to version "0.1.1". This is a critical concern because the current versions of these packages within the repository are "1.2.1" and "1.1.0" respectively. Downgrading to such old versions is likely to reintroduce previously fixed vulnerabilities, cause significant compatibility issues, or lead to application breakage. For internal monorepo packages, using "workspace:^" is the standard and recommended practice to ensure consistency and leverage the latest versions available within the workspace. The yarn.lock warning also suggests potential dependency resolution issues that need manual intervention.

Comment on lines +38 to +39
"@backstage/errors": "0.1.1",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The versions for @backstage/errors and @backstage/types are being downgraded from workspace:^ to 0.1.1. This is a critical issue as the current versions of these packages in the repository are 1.2.1 and 1.1.0 respectively. Downgrading to such an old version is highly likely to reintroduce vulnerabilities, cause breaking changes, or lead to unexpected behavior. For internal monorepo packages, workspace:^ should be maintained to ensure consistency and use the latest versions within the workspace. Please revert these changes to use workspace:^ or update to the latest compatible versions if workspace:^ was causing specific issues (which is unlikely for internal packages).

    "@backstage/errors": "workspace:^",
    "@backstage/types": "workspace:^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants