-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/plugin-search-react from 0.0.0-use.local to 0.1.0 #11666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis pull request updates the dependency management for the ADR plugin by changing the '@backstage/plugin-search-react' dependency from a workspace protocol reference to a fixed version. The change pins the dependency to version 0.1.0 instead of using the dynamic workspace reference (workspace:^). This modification likely indicates a transition from local development dependencies to using a published package version, or addresses version compatibility issues by ensuring a specific version is used rather than relying on the workspace's version resolution. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace Registry
participant NPM as NPM Registry
Note over Dev,NPM: Dependency Resolution Change
Dev->>PM: Install dependencies (before change)
PM->>WS: Resolve @backstage/plugin-search-react@workspace:^
WS-->>PM: Return local workspace package
PM-->>Dev: Dependencies installed (local version)
Note over Dev,NPM: After PR Change
Dev->>PM: Install dependencies (after change)
PM->>NPM: Resolve @backstage/plugin-search-react@0.1.0
NPM-->>PM: Return published package v0.1.0
PM-->>Dev: Dependencies installed (published version)
Note over Dev,NPM: Runtime behavior remains unchanged
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to address security vulnerabilities by upgrading @backstage/plugin-search-react. However, the proposed change in plugins/adr/package.json appears to be a significant downgrade of the @backstage/plugin-search-react dependency from a "workspace:^" version (which typically resolves to 1.x.x in the current workspace) to "0.1.0". This is contrary to the "upgrade" stated in the PR title and description and is highly likely to introduce breaking changes or compatibility issues. Furthermore, the pull request description indicates that the yarn.lock file was not updated, which means the PR is incomplete and requires manual intervention to ensure all dependencies are correctly resolved and the security fix is properly applied.
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/plugin-search-common": "workspace:^", | ||
| "@backstage/plugin-search-react": "workspace:^", | ||
| "@backstage/plugin-search-react": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from "@backstage/plugin-search-react": "workspace:^" to "@backstage/plugin-search-react": "0.1.0" appears to be a significant downgrade. The "workspace:^" typically resolves to the latest version within the monorepo, which for @backstage/plugin-search-react is currently 1.6.4-next.0 (as seen in plugins/search-react/package.json). Downgrading to 0.1.0 is likely to introduce breaking changes and is inconsistent with the "Security upgrade" stated in the PR title. Please verify if 0.1.0 is indeed the correct target version for this security fix, or if a newer, compatible version should be used.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/adr/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
Updated dependency version for '@backstage/plugin-search-react' in the ADR plugin to use a fixed version instead of workspace reference.