Skip to content

[Snyk] Fix for 2 vulnerabilities #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #11667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/devtools-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-devtools-common": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-devtools-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +25 to +34
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces workspace:^ with pinned versions for several @backstage packages. While this might resolve the reported vulnerabilities, this is not the correct approach for a monorepo using Yarn workspaces.

Using workspace:^ ensures that this package uses the local, in-development versions of other packages from the same monorepo. Pinning to specific versions from the registry breaks this link, which can lead to:

  • Inconsistent behavior between local development and CI/production.
  • Difficulties in local development, as changes in other workspace packages won't be reflected here.
  • Potential for multiple versions of the same package in the dependency tree, increasing bundle size and causing subtle bugs.

The PR description also notes that yarn.lock was not updated, which is another major issue.

A better approach would be to update the vulnerable dependencies across the entire monorepo, and then update the yarn.lock file, while keeping the workspace:^ specifiers to maintain the integrity of the monorepo structure.

Because this change fundamentally alters the dependency strategy in a way that is likely to cause problems, it should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/cli-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/config-loader": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-devtools-common": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^"

"@backstage/types": "workspace:^",
"@manypkg/get-packages": "^1.1.3",
"@types/express": "*",
Expand Down
Loading