Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/linguist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-linguist-common": "workspace:^",
"@backstage/plugin-linguist-common": "0.1.0",
Comment on lines +32 to +36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The automated change to pin dependencies is incorrect for this monorepo as it breaks the yarn workspace setup.

  1. @backstage/core-components is severely downgraded from its workspace version (which is 0.13.4-next.0) to 0.8.6. This is a major breaking change and will almost certainly break the application.
  2. Internal packages like these should use workspace:^ to ensure they use the code from within the monorepo, not a separately published version.

These changes should be reverted. The underlying vulnerabilities should be fixed by updating the vulnerable transitive dependencies across the monorepo, for example by using resolutions in the root package.json.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-linguist-common": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading