Skip to content

[Snyk] Fix for 4 vulnerabilities #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 4 vulnerabilities #11670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/tech-insights-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
Comment on lines +36 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions is incorrect for a monorepo using workspaces. This change will cause these dependencies to be fetched from the npm registry instead of using the local source from the workspace, which can lead to version mismatches and breakages. The downgrades for @backstage/catalog-client (from 1.4.3 to 0.2.0) and @backstage/catalog-model (from 1.4.1 to 0.1.1) are especially problematic and will likely cause issues.

The correct way to resolve these vulnerabilities is to keep the workspace:^ specifier and address the underlying vulnerable packages. This can typically be done by:

  1. Running yarn install at the root to update transitive dependencies.
  2. Using the resolutions field in the root package.json to force a non-vulnerable version of the transitive dependencies (rollup, tar, eslint).

The warning in the PR description 'Failed to update the yarn.lock, please update manually before merging' further indicates that this automated change is incorrect.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^"

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
Expand Down
Loading