Skip to content

[Snyk] Security upgrade webpack from 4.46.0 to 5.0.0 #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade webpack from 4.46.0 to 5.0.0 #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@rails/ujs": "^6.0.0",
"@rails/webpacker": "5.4.3",
"turbolinks": "^5.2.0",
"webpack": "^4.46.0",
"webpack": "^5.0.0",
"webpack-cli": "^3.3.12"
Comment on lines 8 to 11
Copy link

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading webpack to version 5 is a major change that introduces breaking changes and requires several other dependencies to be updated for compatibility. The current configuration will likely lead to build failures.

Here are the required changes:

  • @rails/webpacker: Must be upgraded to v6 to support webpack 5. The current version 5.4.3 is not compatible. Note that the latest v6 is a release candidate (6.0.0-rc.6).
  • webpack-cli: Webpack 5 requires webpack-cli v4. The current version ^3.3.12 is incompatible.
  • webpack-dev-server: This is in your devDependencies and also needs to be upgraded to v4 (e.g., ^4.7.3) for webpack 5 compatibility. The current version is ^3.

After updating these dependencies, you will also need to run yarn install to update yarn.lock and you may need to adjust your webpack configuration files (etl/config/webpack/*.js) as per the webpack 5 migration guide.

Suggested change
"@rails/webpacker": "5.4.3",
"turbolinks": "^5.2.0",
"webpack": "^4.46.0",
"webpack": "^5.0.0",
"webpack-cli": "^3.3.12"
"@rails/webpacker": "^6.0.0-rc.6",
"turbolinks": "^5.2.0",
"webpack": "^5.0.0",
"webpack-cli": "^4.9.1"

},
"version": "0.1.0",
Expand Down
Loading