-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 3 vulnerabilities #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading several Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix three medium-severity vulnerabilities by updating dependencies in code/frameworks/sveltekit/package.json. However, the proposed changes are incorrect for this monorepo setup and are highly likely to break the project. The PR replaces internal workspace:* dependencies with pinned, published versions that are inconsistent with the actual package versions in the workspace, including significant downgrades. This fundamentally alters the project's dependency structure. Additionally, the yarn.lock file has not been updated. I've left a critical comment explaining why these changes should be reverted and suggesting the correct approach to mitigate the vulnerabilities within a yarn workspace.
| "@storybook/builder-vite": "0.1.22", | ||
| "@storybook/svelte": "4.0.0", | ||
| "@storybook/svelte-vite": "9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes from Snyk are likely incorrect and will break the project. The dependencies @storybook/builder-vite, @storybook/svelte, and @storybook/svelte-vite are part of this monorepo and are referenced using workspace:* to link to the local packages.
By changing these to specific published versions, you are breaking the internal monorepo dependency graph. Furthermore, the versions being pinned are inconsistent with the versions of these packages within the workspace (8.3.0-beta.3):
@storybook/builder-vite: Downgraded fromworkspace:*(i.e.,8.3.0-beta.3) to0.1.22.@storybook/svelte: Downgraded fromworkspace:*(i.e.,8.3.0-beta.3) to4.0.0.@storybook/svelte-vite: Upgraded fromworkspace:*(i.e.,8.3.0-beta.3) to9.0.0.
These drastic and inconsistent version changes will almost certainly lead to build failures or runtime errors.
The correct way to resolve the underlying vulnerabilities (in tar and eslint) in a monorepo is typically to use resolutions in the root package.json to force a secure version of the transitive dependency across all workspaces, or to update the dependency that brings in the vulnerable package within its own package.json.
Additionally, as noted in the PR description, yarn.lock has not been updated, which is required for any dependency change to take effect.
It is strongly recommended to revert these changes and address the vulnerabilities using a method that is compatible with yarn workspaces.
| "@storybook/builder-vite": "0.1.22", | |
| "@storybook/svelte": "4.0.0", | |
| "@storybook/svelte-vite": "9.0.0" | |
| "@storybook/builder-vite": "workspace:*", | |
| "@storybook/svelte": "workspace:*", | |
| "@storybook/svelte-vite": "workspace:*" |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/sveltekit/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-ESLINT-15102420
SNYK-JS-TAR-15127355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal