Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/server-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:* to a pinned version 7.1.0 is incorrect for a monorepo setup. It breaks the workspace protocol, which intends to use the local version of @storybook/builder-webpack5 (version 8.3.0-beta.3 in this workspace).

Pinning to 7.1.0 is a major version downgrade and will likely introduce breaking changes and build failures. The correct approach to fix the underlying security vulnerability is to update the dependencies of the @storybook/builder-webpack5 package within this monorepo and then update the lockfile, rather than pinning to an old, external version.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/builder-webpack5": "workspace:*",

"@storybook/preset-server-webpack": "workspace:*",
"@storybook/server": "workspace:*",
"@types/node": "^22.0.0"
Expand Down
Loading